Allow both timeLimit and rlimit together #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes we want to set a resource limit _and_ a time limit, where the goal of the former is to have deterministic bounds but the goal of the latter is to ensure timely CI completion. In this case, a good value for the time limit should be much larger than the time we would expect to be required to exceed the resource limit. This will ensure that execution is usually deterministic, but in the rare case where resource count and time are far from each other it'll still guarantee reasonable termination.
keyboardDrummer
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we want to set a resource limit and a time limit, where the goal of the former is to have deterministic bounds but the goal of the latter is to ensure timely CI completion. In this case, a good value for the time limit should be much larger than the time we would expect to be required to exceed the resource limit. This will ensure that execution is usually deterministic, but in the rare case where resource count and time are far from each other it'll still guarantee reasonable termination.